Implement DetermineStrategy for the Kubernetes plugin #5362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cation Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
…gy in determine.go Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
…ifests and determine deployment strategy Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Warashi
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo and
t-kikuc
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5362 +/- ##
==========================================
+ Coverage 25.43% 25.49% +0.06%
==========================================
Files 446 446
Lines 47839 47939 +100
==========================================
+ Hits 12166 12224 +58
- Misses 34721 34762 +41
- Partials 952 953 +1 ☔ View full report in Codecov by Sentry. |
ffjlabo
reviewed
Nov 25, 2024
|
|
||
| // First up, checks to see if the workload's `spec.template` has been changed, | ||
| // and then checks if the configmap/secret's data. | ||
| func determineStrategy(olds, news []provider.Manifest, workloadRefs []config.K8sResourceReference, logger *zap.Logger) (strategy model.SyncStrategy, summary string) { |
There was a problem hiding this comment.
📝 It seems to be based on the current logic decideStrategy
https://github.com/pipe-cd/pipecd/blob/master/pkg/app/piped/planner/kubernetes/kubernetes.go#L233
t-kikuc
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR adds the DetermineStrategy implementation for the k8s plugin.
Why we need it:
We have to support this method to deploy k8s resources.
Which issue(s) this PR fixes:
Part of #4980
Does this PR introduce a user-facing change?: No