Skip to content

Scheduler pipedv1 init logic #5321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 2, 2024
Merged

Scheduler pipedv1 init logic #5321

merged 9 commits into from
Dec 2, 2024

Conversation

khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Nov 8, 2024

What this PR does:

Implement scheduler for pipedv1 (with plugins support). Also remove all not related stub to make scheduler lighter.

Why we need it:

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 47.61905% with 33 lines in your changes missing coverage. Please review.

Project coverage is 25.81%. Comparing base (57f0672) to head (cd755e1).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/controller/scheduler.go 65.21% 15 Missing and 1 partial ⚠️
pkg/configv1/application.go 0.00% 10 Missing ⚠️
pkg/app/pipedv1/controller/controller.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5321      +/-   ##
==========================================
+ Coverage   25.59%   25.81%   +0.22%     
==========================================
  Files         447      445       -2     
  Lines       47993    47859     -134     
==========================================
+ Hits        12283    12357      +74     
+ Misses      34751    34540     -211     
- Partials      959      962       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khanhtc1202 khanhtc1202 marked this pull request as ready for review November 28, 2024 09:37
Copy link
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@khanhtc1202 khanhtc1202 merged commit eb9770c into master Dec 2, 2024
18 checks passed
@khanhtc1202 khanhtc1202 deleted the scheduler-pipedv1 branch December 2, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants