Enabled to configure the interval of livestate store for Lambda #5269
Conversation
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
t-kikuc
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo and
Warashi
as code owners
pkg/config/piped.go
Outdated
| // The interval to fetch the live state of Lambda functions. | ||
| // Default is 15s. | ||
| // To reduce AWS API calls, this interval should be larger. | ||
| LiveStateInterval Duration `json:"liveStateInterval,omitempty" default:"15s"` |
There was a problem hiding this comment.
How about to make this general name like awsAPICallInterval. Since we are going to migrate platform to plugin, I want to ensure less configuration update as possible in the mean time.
There was a problem hiding this comment.
I think liveStateInterval will not change while migrating to the plugin.
Plugin will change the name of the LiveState feature??
There was a problem hiding this comment.
No, I mean if we allow some name like this in the configuration, then we would have something like driftDetectionInterval later, which I think should not be here (in the piped.platformProvider config). Livestate or Drift detection config should not be related directly to platform, is what I tried to explain. Name like awsAPICallInterval is more relevant.
There was a problem hiding this comment.
Also, I want to ensure we do not add names/configs that will be changed too much later due to the migrating cost when the user moves to use the plugin-piped. That's why I said, I don't think the used name is good.
There was a problem hiding this comment.
I almost agree with @khanhtc1202 that we can name this configuration a generic word, but I think awsAPICallInterval is a bit confusing because it sounds like a rate-limiting feature.
We call AWS APIs in other functionality, such as deployment, and they are not affected by this configuration.
What about like awsAPIPollingInterval?
There was a problem hiding this comment.
The name awsAPIPollingInterval is lgtm 👍
There was a problem hiding this comment.
@khanhtc1202 @Warashi
Thank you, I changed to awsAPIPollingInterval
Signed-off-by: t-kikuc <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5269 +/- ##
==========================================
+ Coverage 24.08% 24.27% +0.18%
==========================================
Files 441 440 -1
Lines 47099 46754 -345
==========================================
+ Hits 11345 11348 +3
+ Misses 34850 34502 -348
Partials 904 904 ☔ View full report in Codecov by Sentry. |
Signed-off-by: t-kikuc <[email protected]>
* add liveStateInterval for Lambda Signed-off-by: t-kikuc <[email protected]> * add docs of liveStateInterval Signed-off-by: t-kikuc <[email protected]> * fix a test Signed-off-by: t-kikuc <[email protected]> * Rename to 'awsAPIPollingInterval' Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> Signed-off-by: pipecd-bot <[email protected]>
* Fix the workflow publishes quickstart manifests (#5266) * Add pull-requests permission to the workflow Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Set the base branch to the default branch of the repository Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Use `github.ref_name` to determine the version of manifests Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Checkout master branch to make PR to master branch Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> --------- Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Remove pipectl quickstart command (#5268) * Remove pipectl quickstart command Signed-off-by: khanhtc1202 <[email protected]> * Remove the quickstart from docs Signed-off-by: khanhtc1202 <[email protected]> --------- Signed-off-by: khanhtc1202 <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Enabled to configure the interval of livestate store for Lambda (#5269) * add liveStateInterval for Lambda Signed-off-by: t-kikuc <[email protected]> * add docs of liveStateInterval Signed-off-by: t-kikuc <[email protected]> * fix a test Signed-off-by: t-kikuc <[email protected]> * Rename to 'awsAPIPollingInterval' Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Update RELEASE to v0.49.2 and sync docs of v0.49.x (#5272) Signed-off-by: t-kikuc <[email protected]> Signed-off-by: pipecd-bot <[email protected]> --------- Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> Signed-off-by: pipecd-bot <[email protected]> Signed-off-by: khanhtc1202 <[email protected]> Signed-off-by: t-kikuc <[email protected]> Co-authored-by: Shinnosuke Sawada-Dazai <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Co-authored-by: Tetsuya Kikuchi <[email protected]>
What this PR does / why we need it:
What for:
Which issue(s) this PR fixes:
N/A
Does this PR introduce a user-facing change?: