Add custom sync rollback other than lambda #4285
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Khanh Tran <[email protected]>
kevin-namba
requested review from
nghialv,
khanhtc1202 and
knanao
as code owners
kevin-namba
changed the title
kevin-namba
changed the title
sivchari
reviewed
May 28, 2023
| @@ -78,6 +78,7 @@ func buildProgressivePipeline(pp *config.DeploymentPipeline, autoRollback bool, | |||
| out = make([]*model.PipelineStage, 0, len(pp.Stages)) | |||
| ) | |||
|
|
|||
| shouldRollbackCustomSync := false | |||
There was a problem hiding this comment.
Suggested change
| shouldRollbackCustomSync := false | |
| var shouldRollbackCustomSync bool |
| @@ -31,6 +31,7 @@ func buildQuickSyncPipeline(autoRollback bool, now time.Time) []*model.PipelineS | |||
| out = make([]*model.PipelineStage, 0, len(stages)) | |||
| ) | |||
|
|
|||
| shouldRollbackCustomSync := false | |||
| @@ -31,6 +31,7 @@ func buildQuickSyncPipeline(autoRollback bool, now time.Time) []*model.PipelineS | |||
| out = make([]*model.PipelineStage, 0, len(stages)) | |||
| ) | |||
|
|
|||
| shouldRollbackCustomSync := false | |||
| @@ -78,6 +96,7 @@ func buildProgressivePipeline(pp *config.DeploymentPipeline, autoRollback bool, | |||
| out = make([]*model.PipelineStage, 0, len(pp.Stages)) | |||
| ) | |||
|
|
|||
| shouldRollbackCustomSync := false | |||
| @@ -72,6 +72,7 @@ func buildProgressivePipeline(pp *config.DeploymentPipeline, autoRollback bool, | |||
| out = make([]*model.PipelineStage, 0, len(pp.Stages)) | |||
| ) | |||
|
|
|||
| shouldRollbackCustomSync := false | |||
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
This PR was closed because it has been stalled for 7 days with no activity. Feel free to reopen if still applicable. |
github-actions
bot
deleted the
add-custom-sync-rollback-other-than-lambda
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
support custom sync rollback other than lambda
Which issue(s) this PR fixes:
Fixes #1089
Does this PR introduce a user-facing change?: