-
-
Notifications
You must be signed in to change notification settings - Fork 6
Allow customizing the quoting behavior of emit. #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
enhancement
New feature or request
Comments
TimHambourger
pushed a commit
to TimHambourger/rsql
that referenced
this issue
Jul 4, 2022
TimHambourger
pushed a commit
to TimHambourger/rsql
that referenced
this issue
Jul 8, 2022
TimHambourger
pushed a commit
to TimHambourger/rsql
that referenced
this issue
Jul 8, 2022
TimHambourger
pushed a commit
to TimHambourger/rsql
that referenced
this issue
Jul 8, 2022
piotr-oles
pushed a commit
that referenced
this issue
Jul 8, 2022
Add an optional second parameter to emit to customize quotes output Co-authored-by: Tim Hambourger <[email protected]>
Implemented in #35 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
This is definitely a nice-to-have, not an urgent need. Something I noticed while working on #32 is that the emitter has good internal support for using either quote character (double or single) to escape comparison values, but that
emit
itself currently only supports using the double quote character. Among other things, this means the emitted RSQL can end up being longer than it it needs to be if the AST being emitted contains a lot of comparison values with double quotes in them.Describe the solution you'd like
I'd propose adding an optional second parameter to
emit
giving it the following signature:I'll submit a PR for this in just a min.
The text was updated successfully, but these errors were encountered: