-
Notifications
You must be signed in to change notification settings - Fork 321
Open
Labels
difficulty/mediumIndicates that a issue is medium to resolve.Indicates that a issue is medium to resolve.good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.type/enhancementCategorizes issue or PR as related to an enhancement.Categorizes issue or PR as related to an enhancement.
Description
Some of our unit tests are more like integration tests at the moment in that they test more than one stage in the TiUp pipeline. It is better practice to test this sort of thing in integration tests and for unit tests to test small, modular actions. In particular, unit tests should almost never do IO. Doing this will require some mocking of interfaces and extracting interfaces where there are currently only concrete types
lucklove
Metadata
Metadata
Assignees
Labels
difficulty/mediumIndicates that a issue is medium to resolve.Indicates that a issue is medium to resolve.good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.type/enhancementCategorizes issue or PR as related to an enhancement.Categorizes issue or PR as related to an enhancement.