Skip to content

kafka(ticdc): bump sarama fix kafka stuck (#12134) #12138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #12134

What problem does this PR solve?

Issue Number: close #12110

What is changed and how it works?

  • replace the ibm/sarama by the pingcap/sarama

This PR fix the kafka sink stuck problem, caused by the downstream kafka cluster throttling.

The pingcap/sarama is forked from the IBM/sarama, only cherry-pick necessary bug fix PR IBM/sarama#2826. The v1.41.2-pingcap-20250415 is based on the release v1.41.2

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

bump sarama version to fix the kafka stuck when the kafka cluster throttling

@ti-chi-bot ti-chi-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Apr 15, 2025
@ti-chi-bot
Copy link
Member Author

@3AceShowHand This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-12134-to-release-8.5 branch from 607d747 to 8b32c6d Compare April 15, 2025 08:04
@3AceShowHand 3AceShowHand force-pushed the cherry-pick-12134-to-release-8.5 branch from 10ece36 to fdc5b32 Compare April 15, 2025 08:13
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.5@a798ace). Learn more about missing BASE report.

Additional details and impacted files
Components Coverage Δ
cdc 59.5397% <0.0000%> (?)
dm 50.0500% <0.0000%> (?)
engine 53.2336% <0.0000%> (?)
Flag Coverage Δ
unit 55.1183% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-8.5     #12138   +/-   ##
================================================
  Coverage               ?   55.1183%           
================================================
  Files                  ?       1003           
  Lines                  ?     136764           
  Branches               ?          0           
================================================
  Hits                   ?      75382           
  Misses                 ?      55847           
  Partials               ?       5535           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 15, 2025
@3AceShowHand
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 16, 2025
@3AceShowHand
Copy link
Contributor

/retest

Copy link
Contributor

ti-chi-bot bot commented Apr 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 16, 2025
@3AceShowHand
Copy link
Contributor

/retest

@3AceShowHand
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 080a4c8 into pingcap:release-8.5 Apr 16, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants