Skip to content

notifyUpdatePrivilege misses timeout deadline on etcd operation #61184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
qts0312 opened this issue May 19, 2025 · 0 comments · Fixed by #61286
Closed

notifyUpdatePrivilege misses timeout deadline on etcd operation #61184

qts0312 opened this issue May 19, 2025 · 0 comments · Fixed by #61286
Labels
severity/minor sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.

Comments

@qts0312
Copy link
Contributor

qts0312 commented May 19, 2025

Bug Report

Function notifyUpdatePrivilege in pkg/domain/domain.go does not set timeout deadline for etcd operation Put. The context of domain is used directly. Therefore, notifyUpdatePrivilege can be stuck by the Put for really long time.

_, err = row.Put(do.ctx, privilegeKey, string(data))

1. Minimal reproduce step (Required)

Any query that invokes notifyUpdatePrivilege.

2. What did you expect to see? (Required)

row.Put(do.ctx, privilegeKey, string(data)) returns DeadlineExceeded.

3. What did you see instead (Required)

row.Put(do.ctx, privilegeKey, string(data)) is stuck, and further block notifyUpdatePrivilege endlessly.

4. What is your TiDB version? (Required)

v8.5.0

@qts0312 qts0312 added the type/bug The issue is confirmed as a bug. label May 19, 2025
@Defined2014 Defined2014 added sig/sql-infra SIG: SQL Infra severity/minor and removed sig/sql-infra SIG: SQL Infra labels May 22, 2025
@jebter jebter added the sig/sql-infra SIG: SQL Infra label May 23, 2025
@ti-chi-bot ti-chi-bot bot closed this as completed in 3634a3c May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/minor sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants