We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Function NotifyUpdateSysVarCache in pkg/domain/domain.go does not set a timeout deadline for etcd request Put
NotifyUpdateSysVarCache
pkg/domain/domain.go
Put
_, err := row.Put(context.Background(), sysVarCacheKey, "")
As the background context will never be canceled, this function will stuck endlessly when the etcd request meets a timeout error.
Any statements related to NotifyUpdateSysVarCache, for example
set global tidb_enable_check_constraint=ON;
row.Put(context.Background(), sysVarCacheKey, "") returns DeadlineExceeded.
row.Put(context.Background(), sysVarCacheKey, "")
DeadlineExceeded
row.Put(context.Background(), sysVarCacheKey, "") is stuck, and further block NotifyUpdateSysVarCache endlessly.
v8.5.0
The text was updated successfully, but these errors were encountered:
fixed by PR #61154
Sorry, something went wrong.
a465b18
Successfully merging a pull request may close this issue.
Bug Report
Function
NotifyUpdateSysVarCache
inpkg/domain/domain.go
does not set a timeout deadline for etcd requestPut
As the background context will never be canceled, this function will stuck endlessly when the etcd request meets a timeout error.
1. Minimal reproduce step (Required)
Any statements related to
NotifyUpdateSysVarCache
, for example2. What did you expect to see? (Required)
row.Put(context.Background(), sysVarCacheKey, "")
returnsDeadlineExceeded
.3. What did you see instead (Required)
row.Put(context.Background(), sysVarCacheKey, "")
is stuck, and further blockNotifyUpdateSysVarCache
endlessly.4. What is your TiDB version? (Required)
v8.5.0
The text was updated successfully, but these errors were encountered: