fix some, int test still broken

Signed-off-by: Wenqi Mou <[email protected]>

Author: Tristan1900

br/pkg/checkpoint/name.go

@@ -30,7 +30,7 @@ type TableIdentifier struct {
 // GenerateTableNameSuffix generates a unique suffix for checkpoint table names based on restore parameters
 func (t *TableIdentifier) GenerateTableNameSuffix() string {
 	// combine all parameters into a unique string
-	uniqueStr := fmt.Sprintf("%d-%d-%s-%s-%d-%s",
+	uniqueStr := fmt.Sprintf("%d-%d-%s-%d-%s",
 		t.StartTS,
 		t.EndTS,
 		t.Filter,

br/pkg/checkpoint/name_test.go

@@ -0,0 +1,35 @@
+package checkpoint
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/require"
+)
+
+func TestTableIdentifier(t *testing.T) {
+	identifier := TableIdentifier{
+		StartTS:           1704067200000, // 2024-01-01 00:00:00
+		EndTS:             1704153600000, // 2024-01-02 00:00:00
+		Filter:            []string{"db1.table1", "db2.*", "*.table3", "db4.table4"},
+		UpstreamClusterID: 987654321,
+		TaskType:          "incremental-restore",
+	}
+
+	suffix := identifier.GenerateTableNameSuffix()
+
+	// length check, "_" + 16 hex chars
+	require.Equal(t, 17, len(suffix))
+
+	// first item check
+	require.Equal(t, byte('_'), suffix[0])
+
+	// generate again to verify deterministic behavior
+	secondSuffix := identifier.GenerateTableNameSuffix()
+	require.Equal(t, secondSuffix, suffix)
+
+	// verify that changing any field produces a different suffix
+	modifiedIdentifier := identifier
+	modifiedIdentifier.Filter = []string{}
+	differentSuffix := modifiedIdentifier.GenerateTableNameSuffix()
+	require.NotEqual(t, suffix, differentSuffix)
+}

br/pkg/checkpoint/storage.go

@@ -249,7 +249,8 @@ func selectCheckpointChecksum(
 ) (map[int64]*ChecksumItem, time.Duration, error) {
 	var pastDureTime time.Duration = 0
 	checkpointChecksum := make(map[int64]*ChecksumItem)
-	checkpointChecksums, err := mergeSelectCheckpoint(ctx, execCtx, dbName, GetCheckpointTableName(checkpointChecksumTableNamePrefix, tableSuffix))
+	checkpointChecksums, err := mergeSelectCheckpoint(ctx, execCtx, dbName,
+		GetCheckpointTableName(checkpointChecksumTableNamePrefix, tableSuffix))
 	if err != nil {
 		return checkpointChecksum, pastDureTime, errors.Trace(err)
 	}