Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive dropdown toggle #99

Merged
merged 5 commits into from
Aug 27, 2014
Merged

Responsive dropdown toggle #99

merged 5 commits into from
Aug 27, 2014

Conversation

nervetattoo
Copy link
Contributor

This adds support for dropdown toggles going full-width on small screens, just like in the vanilla foundation.
It also moves mediaQueries to its own module, mm.foundation.mediaQueries, so it can be reused.
Fixes #98

@nervetattoo nervetattoo changed the title Responsive dropdown toggle. Fixes #98 Responsive dropdown toggle Aug 21, 2014
@nervetattoo
Copy link
Contributor Author

I also added some logic to make sure the dropdown does not overflow out of the screen on the right hand when the initiating button is placed far out.
Instead it aligns the dropdown with an 8px padding on the right hand side and forces the pip to be right-sided.

@nervetattoo nervetattoo mentioned this pull request Aug 27, 2014
@circlingthesun
Copy link
Contributor

👍

@jbrowning
Copy link
Member

This is awesome, especially the separation of mediaQueries into a separate module. 😌

  1. Can you please add some mediaQueries module docs for the demo page?
  2. Are there any mediaQueries-related specs we should move into specs for the mediaQueries module?

@nervetattoo
Copy link
Contributor Author

I didn't find any specs covering the mediaQueries part when I looked.
I've at least pushed a readme for the module now.

@jbrowning
Copy link
Member

👍 thanks!

jbrowning added a commit that referenced this pull request Aug 27, 2014
@jbrowning jbrowning merged commit ef2a8d5 into yalabot:master Aug 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dropdownToggle responsiveness
3 participants