You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We're missing the responsiveness of the dropdownToggle from vanilla foundation.
I'm willing to patch this but I need some general input on how to proceed:
mm.foundation.topbar has a mediaQueries factory.
Why is this restricted to the topBar module?
Making other directives responsive seems hard when you can't grab this without loading the topbar-module.
Are there any descriptions about how to open a demo of a single directive locally behind connect?
And how do you go about writing specs for responsiveness?
I figured I'd ask before just creating a PR ;)
The text was updated successfully, but these errors were encountered:
The mediaQueries factory really needs to be moved to a seperate module. Testing resposiveness is problematic as modern day browsers prevent window resizing. You can look at the topbar specs for some ideas how to test resposiveness. Before moving media queries into a service I mocked the $window.matchMedia function to return true for whatever break point I was trying to test for. Now that its a service you should probablty just mock it to exibit the desired screen size behaviour.
We're missing the responsiveness of the dropdownToggle from vanilla foundation.
I'm willing to patch this but I need some general input on how to proceed:
mm.foundation.topbar has a mediaQueries factory.
Why is this restricted to the topBar module?
Making other directives responsive seems hard when you can't grab this without loading the topbar-module.
Are there any descriptions about how to open a demo of a single directive locally behind connect?
And how do you go about writing specs for responsiveness?
I figured I'd ask before just creating a PR ;)
The text was updated successfully, but these errors were encountered: