Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dropdownToggle responsiveness #98

Closed
nervetattoo opened this issue Aug 20, 2014 · 1 comment · Fixed by #99
Closed

dropdownToggle responsiveness #98

nervetattoo opened this issue Aug 20, 2014 · 1 comment · Fixed by #99

Comments

@nervetattoo
Copy link
Contributor

We're missing the responsiveness of the dropdownToggle from vanilla foundation.
I'm willing to patch this but I need some general input on how to proceed:

mm.foundation.topbar has a mediaQueries factory.
Why is this restricted to the topBar module?
Making other directives responsive seems hard when you can't grab this without loading the topbar-module.

Are there any descriptions about how to open a demo of a single directive locally behind connect?
And how do you go about writing specs for responsiveness?

I figured I'd ask before just creating a PR ;)

@circlingthesun
Copy link
Contributor

The mediaQueries factory really needs to be moved to a seperate module. Testing resposiveness is problematic as modern day browsers prevent window resizing. You can look at the topbar specs for some ideas how to test resposiveness. Before moving media queries into a service I mocked the $window.matchMedia function to return true for whatever break point I was trying to test for. Now that its a service you should probablty just mock it to exibit the desired screen size behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants