Skip to content

ci: update ci workflow and remove appveyor #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

Phillip9587
Copy link
Contributor

@Phillip9587 Phillip9587 commented Feb 18, 2025

I noticed that the current CI workflow in this repository could benefit from some updates. Specifically:

  1. The Coverage setup could also be optimized:

    • Currently, the workflow uses the coverallsapp/github-action@master which points to v1 of this action. This v1 action uses node16 as runtime which is deprecated.
  2. Minimum token permissions for the GITHUB_TOKEN:

  3. lint step

    • I created an extra lint step similar to the workflow of the main express repo.
  4. Test Matrix

    • I added Node.js v19, v21 and v23 to the test matrix to test all supported Node.js versions.
    • I added windows-latest and ubuntu-latest to the test matrix to test on both
  5. Removed obsolete AppVeyor

    • Removed obsolete appveyor.yml file
    • Removed the appveyor badge from README.md
  6. Updated test scripts in package.json

    • removed --bail from the test script
    • use lcovonly reporter for the test-ci script to skip creation of the html report in CI

@Phillip9587 Phillip9587 mentioned this pull request Mar 27, 2025
@UlisesGascon UlisesGascon merged commit a440be7 into pillarjs:master Mar 27, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants