ci: update ci workflow and remove appveyor #249
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the current CI workflow in this repository could benefit from some updates. Specifically:
The Coverage setup could also be optimized:
coverallsapp/github-action@master
which points to v1 of this action. This v1 action usesnode16
as runtime which is deprecated.Minimum token permissions for the GITHUB_TOKEN:
lint step
lint
step similar to the workflow of the main express repo.Test Matrix
windows-latest
andubuntu-latest
to the test matrix to test on bothRemoved obsolete AppVeyor
appveyor.yml
fileREADME.md
Updated test scripts in package.json
--bail
from thetest
scriptlcovonly
reporter for thetest-ci
script to skip creation of the html report in CI