Skip to content

Update github user reference #1598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

alexis-opolka
Copy link
Contributor

@alexis-opolka alexis-opolka commented Jun 11, 2024

Description

GitHub doesn't link usernames in the README, if we want to reference the user it should be as a link.

My Pull Request only modifies this tiny bit in the README.

Motivation and Context

I just want others to be able to land on Rikj000's profile page on GitHub.

How Has This Been Tested?

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@yubiuser
Copy link
Member

Thanks for your contribution. Please target development-v6 branch, squash your commits down and sign them off. See https://docs.pi-hole.net/guides/github/dco/

@alexis-opolka alexis-opolka changed the base branch from dev to development-v6 June 12, 2024 01:09
Signed-off-by: alexis-opolka <[email protected]>
@alexis-opolka
Copy link
Contributor Author

It should be good now, my branch should be in accord with the targeted development-v6 branch and only one commit, now signed, should appear.

@yubiuser yubiuser requested a review from PromoFaux June 12, 2024 10:26
@PromoFaux PromoFaux merged commit 56c110a into pi-hole:development-v6 Jun 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants