Fixed ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO macro #2523
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The macro was expanding to a wrong macro and thus leads to compile errors upon usage. Changed it to expand to the correct macro, and added Doxygen documentation to help new users.
Thanks Visual Studio ;(
Closed
|
The technical change here can be easily merged, but the added documentation will require an internals discussion. We do not currently use Doxygen and as such we also do not use Doxygen-style comments anywhere in the codebase. If we want to start making use of Doxygen, this needs to be discussed first. |
|
I can change the style to whatever is used, the thing is, there is no documentation. However, having it would greatly improve the accessibility of internals for others. Update: Opened discussion on internals. |
|
Please link to discussion for reference. |
|
Internals Discussion: http://news.php.net/php.internals/99140 |
|
Applied in 66e5dc5 |
basvanbeek
added a commit
to census-instrumentation/opencensus-php
that referenced
this pull request
Jan 16, 2019
…etween versions, see: php/php-src#2523
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macro was expanding to a wrong macro and thus lead to compile errors upon usage. Changed it to expand to the correct macro, and added Doxygen documentation to help new users.
This is a pure internals fix, hence, I doubt that we want a real PHP bug report for this.