Skip to content

chore: try running tests against PHP 8.5 as an experimental job #1700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

chore: try running tests against PHP 8.5 as an experimental job #1700

wants to merge 13 commits into from

Conversation

alexandre-daubois
Copy link
Contributor

No description provided.

@AlliBalliBaba
Copy link
Contributor

AlliBalliBaba commented Jun 28, 2025 •
edited
Loading

Tests do work locally if I install 8.5.0-dev from master.

@alexandre-daubois
Copy link
Contributor Author

alexandre-daubois commented Jun 29, 2025 •
edited
Loading

CI took hours to get triggered, I forgot about it. Thank you for testing, I'll try triggering the CI again!

Edit: hmmm, seems a segfault appears. I'll try to investigate about it. It's also green on macOS on my side.

@alexandre-daubois alexandre-daubois marked this pull request as draft June 29, 2025 11:57
@alexandre-daubois alexandre-daubois force-pushed the php-85 branch 6 times, most recently from e4f67c3 to 8aa38e0 Compare June 29, 2025 12:13
@AlliBalliBaba
Copy link
Contributor

Kind of looks like the installed PHP8.5 version is not ZTS, maybe the setup-php action doesn't support that yet.

@alexandre-daubois
Copy link
Contributor Author

That was a nice idea! Unfortunately, php -v in the CI outputs:

PHP 8.5.0-dev (cli) (built: Jun 29 2025 00:37:29) (ZTS)

@alexandre-daubois alexandre-daubois force-pushed the php-85 branch 2 times, most recently from ab9ec8d to c933401 Compare June 29, 2025 13:28
@alexandre-daubois alexandre-daubois force-pushed the php-85 branch 2 times, most recently from f29d6bd to e8c6b9d Compare June 29, 2025 13:55
@AlliBalliBaba
Copy link
Contributor

It failing at (void)ts_resource(0); probably means there's something weird about the nightly build with ZTS.

It's strange though that the version looks correct. Locally I just replaced the branch with master here, which seems to work.

Kind of annoying that this only happens in the pipeline, but the good old 'logging every line' has also never failed me before 😅

@alexandre-daubois
Copy link
Contributor Author

alexandre-daubois commented Jun 29, 2025 •
edited
Loading

Same conclusion as you! Indeed, turns out this line makes the program segfault:

frankenphp/frankenphp.c

Line 856 in 291dd4e

(void)ts_resource(0);

It doesn't seem there are significant changes between 8.4 and 8.5, maybe it's an external dependency problem... 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandre-daubois @AlliBalliBaba