Skip to content

[Backport]3437-Adding-an-instance-class-variable-remove-the-traits-of-a-class #3438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 15, 2019
Merged

[Backport]3437-Adding-an-instance-class-variable-remove-the-traits-of-a-class #3438

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2e77f2
Backport fix in class slot addition.
jecisc May 29, 2019
1d04cf1
Also backport changes to #fillFor:
jecisc May 29, 2019
f798005
Revert "Also backport changes to #fillFor:"
jecisc May 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions src/Shift-ClassInstaller/Class.extension.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,8 @@ Class >> addClassSlot: aSlot [

^ self classInstaller update: self to: [ :builder |
builder
superclass: self superclass;
name: self name;
layoutClass: self classLayout class;
slots: self slots;
classSlots: (self class classLayout slots copyWith: aSlot);
sharedVariablesFromString: self classVariablesString;
sharedPools: self sharedPoolsString;
category: self category;
environment: self environment;
copyClassSlotsFromExistingClass ]
fillFor: self;
classSlots: (self class classLayout slots copyWith: aSlot) ]
]

{ #category : #'*Shift-ClassInstaller' }
Expand Down