Fix comment on OSWindow >> startTextInput #2781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! The current dev branch is Pharo8, but I think I will just merge this in Pharo 7 and then do another PR for Pharo8. |
|
@MarcusDenker do you know if this was forward ported to Pharo8? |
|
yes! #2798 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a small problem in the comment on OSWindow's startTextInput method. I updated the comment to something I think should make it a little bit more clear.
I read the contributing guidelines but I'm still not certain I submitted this sort of change quite correctly. Specifically, I am not quite sure what the current development branch is.
If there's anything I can do on this or future PRs to make reviewing it is easier for the maintainers, please let me know.
Thanks much!