Ensure subMenu is opened (backport) #2376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why this backport? why this is a critical fix? |
|
It breaks client code |
|
why? AFAIK, this never worked before (or it does not works since a lot of time). |
|
It worked in Pharo 6. I have code that needs to work in Pharo 7 so I need the fix backported |
|
unrelated failures |
|
now that I remember, there was a reason why this was removed. |
jecisc
approved these changes
Feb 5, 2019
|
Before each menu constructor was duplication the logic. I changed it to build in one method and have the other ones calling this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves Issue #2331, #2333. Backport for Pharo 7. See 22084 in Fogbugz