Fix Duplicate class refactoring if there are spaces in package or package tag #18289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kage tag Currently StRequestClassPresenter is checking if the name of a class, package and package tag are right. But is expects that we have no space in the package name or package tag name. But it is possible to have spaces there in Pharo! Update the check. Fixes pharo-project#18287
balsa-sarenac
approved these changes
Jun 17, 2025
jecisc
added a commit
that referenced
this pull request
Jun 18, 2025
Backport #18289 to P13: Fix Duplicate class refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently StRequestClassPresenter is checking if the name of a class, package and package tag are right. But is expects that we have no space in the package name or package tag name. But it is possible to have spaces there in Pharo!
Update the check.
Fixes #18287
@balsa-sarenac I added tests but I find it hard to setup the presenters. For one I had to use a #basicNew because the initialize is opening a modal which make it really tricky to test. I think some cleaning is necessary to make it easier to test