Remove dependency of Network-Mail to Morphic #18103
Merged
+0
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MailMessage has some dependencies over Morphic and UIManager to be able to view a MailMessage content. I propose to move those methods to NewTools and to use Spec instead of Morphic to view the content. I already did a PR to NewTools so we can just remove those two methods from Pharo. pharo-spec/NewTools#1104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MailMessage has some dependencies over Morphic and UIManager to be able to view a MailMessage content.
I propose to move those methods to NewTools and to use Spec instead of Morphic to view the content.
I already did a PR to NewTools so we can just remove those two methods from Pharo.
pharo-spec/NewTools#1104