Simplify progress bar theme management #17283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The theme management of the progress bar is a little messy because it gives a progress bar parameter that is never used. And some methods have "style" in the name but they should return colors. Here is a pass to simplify this. I'll then do a next step to ensure that Spec is using those methods to theme the progress bars in Spec because this is not the case currently
|
again a segmenation fault on loading, but another package (was before when loading spec, now on newtools). I opened #17286 |
MarcusDenker
approved these changes
Oct 21, 2024
jordanmontt
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The theme management of the progress bar is a little messy because it gives a progress bar parameter that is never used. And some methods have "style" in the name but they should return colors.
Here is a pass to simplify this. I'll then do a next step to ensure that Spec is using those methods to theme the progress bars in Spec because this is not the case currently