Skip to content

Use allNonMetaClasses in Duplicate Class driver #17263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2024
Merged

Use allNonMetaClasses in Duplicate Class driver #17263

merged 2 commits into from
Oct 16, 2024

Conversation

hernanmd
Copy link
Member

Use allNonMetaClasses to prevent getting metaclasses where are not needed, as reported in #17262

@hernanmd hernanmd self-assigned this Oct 13, 2024
@Ducasse
Copy link
Member

Ducasse commented Oct 13, 2024

this look strange beacause we have many rb test broken

osx-64 / Tests-osx-64 / MacOSX64.Refactoring.Core.Tests.ReMethodsSendNoSupersendsTest.testMethodSendingMessageToSuper
osx-64 / Tests-osx-64 / MacOSX64.Refactoring.Transformations.Tests.RBPullUpMethodParametrizedTest.testPullUpMethodWithCopyOverriddenMethodsDown(#rbClass->RePullUpMethodRefactoring)
unix-64 / Tests-unix-64 / Unix64.Debugging.Utils.Tests.HaltTest.testHaltOnCount
unix-64 / Tests-unix-64 / Unix64.Refactoring.Core.Tests.ReMethodsSendNoSupersendsTest.testMethodSendingMessageToSuper
unix-64 / Tests-unix-64 / Unix64.Refactoring.Transformations.Tests.RBPullUpMethodParametrizedTest.testPullUpMethodWithCopyOverriddenMethodsDown(#rbClass->RePullUpMethodRefactoring)
unix-64

@hernanmd hernanmd closed this Oct 15, 2024
@hernanmd hernanmd reopened this Oct 15, 2024
@hernanmd hernanmd requested a review from Ducasse October 15, 2024 19:19
@jecisc jecisc merged commit 9d19b62 into pharo-project:Pharo13 Oct 16, 2024
1 of 2 checks passed
@hernanmd
Copy link
Member Author

Thanks!

@hernanmd hernanmd deleted the p13-dup-cls-use-allNonMetaClasses branch November 16, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jecisc jecisc jecisc approved these changes

@Ducasse Ducasse Awaiting requested review from Ducasse

Assignees

@hernanmd hernanmd

Labels
Easy Project: Refactorings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hernanmd @Ducasse @jecisc