Skip to content

Make finder more configurable #17115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jecisc
Copy link
Member

@jecisc jecisc commented Sep 16, 2024

The finder currently has code overriden by NewTools because NewTools need more configurability in the MethodFinder.

I propose to make the Finder more configurable directly in Pharo so that we can remove this code overriding Pharo code in NewTools and have a cleaner image.

The finder currently has code overriden by NewTools because NewTools need more configurability in the MethodFinder. 

I propose to make the Finder more configurable directly in Pharo so that we can remove this code overriding Pharo code in NewTools and have a cleaner image.
jecisc added a commit to jecisc/NewTools that referenced this pull request Sep 16, 2024
This PR is the NewTools pending of this one: pharo-project/pharo#17115

With that we avoid to override code from Pharo in NewTools
@jecisc
Copy link
Member Author

jecisc commented Sep 16, 2024

NewTools pending PR: pharo-spec/NewTools#837

@MarcusDenker MarcusDenker merged commit bb0227f into pharo-project:Pharo13 Sep 17, 2024
1 of 2 checks passed
@Ducasse
Copy link
Member

Ducasse commented Sep 19, 2024

This is great to remove such extensions.
Yesterday we spent a couple of hours analysis extension usage and we spotted
other places where methods are not coherently packaged (like a hook is introduced by a package using extension but the superclass has subclassResponsibility that is not part of the extending package and there is no user beside the extending package, or notify.... in command refactoring). We should open a list of issues

@jecisc jecisc deleted the misc/make-finder-more-configurable branch November 5, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants