Speed up more refactoring tests by constricting the refactoring model #17010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…paceTest constraining the model in tests where this is possible
…factoring tests made the dependency explicit.
…eSendParametrizedTest by constricting their model
|
Hi @MarcusDenker , I have a single failing test |
|
I think it might be related to a change of @hernanmd on spec? |
|
Yes so let us know when your PR is ready to integrate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Work in progress, do not review yet)
Refactoring tests take too long to run, this PR constrains the model of many refactoring tests (specifically parametriezed tests) to make them run faster.
This PR is a continuation of PR#16807.
This PR does not speed up all refactoring tests. This work will continue in future PRs