Move #isRoot to fast table #16800
Merged
Move #isRoot to fast table #16800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iceberg is adding #isRoot methods to FastTable and currently the users of this methods are in the Spec morphic adapter. IMO their place are not in Iceberg. I first was thinking about putting this code in Spec but it seems generic enough to put it directly into FastTable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iceberg is adding #isRoot methods to FastTable and currently the users of this methods are in the Spec morphic adapter.
IMO their place are not in Iceberg. I first was thinking about putting this code in Spec but it seems generic enough to put it directly into FastTable.
I also cleaned some protocols