-
-
Notifications
You must be signed in to change notification settings - Fork 393
Adds a simple MoveTo taskbar menu item #16544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a simple MoveTo taskbar menu item #16544
Conversation
I meant to add this to Pharo12 but didn't get to it in time (and I know many people hate the taskbar and lots of windows - but I'm ok with them, and just like to have a few of them at the front and then I clean up the other windows at the end of the list) |
Hi tim Thanks. I think that in the future we should a pre-release announce :). S |
Just to make it more obvious (as per @Ducasse feedback) - its adds a 3rd option to the move tab menu And then lets you pick an absolute location: Entering 1 will put the selected task item at the beginning on the list. |
Ah ok yes now I understand. |
taskBarSize := self worldTaskbar orderedTasks size. | ||
taskLocation := self worldTaskbar orderedTasks indexOf: self taskbarTask. | ||
|
||
answer := UIManager default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that Stephane wants us to reduce the references to UIManager. But Spec is loaded after SystemWindow so I am not so sure of how to do what you are doing without UIManager. Maybe @Ducasse or @estebanlm know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just needs a simple way to ask for input - so presumably there is a recommended way to do this going forward and I can adjust and resubmit.
Worth adding, I've tried to use the taskbar primitives already there to keep the api as small as possible in case there are changes proposed in this area.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:( shitty architecture strikes back. Now SystemWindow is in morphic so I do not care. we should kill it alltogether.
Now this behavior will have to be redone on top of Toplo (and not the spec backend)
Would it help to have some kind of indirection to ask yes/no numeric questions? At least you could potentially slot something else in place when it's ready? |
I do not know but after we will see because we will have to redo some basic things in Toplo |
Adds a simple MoveTo menu item for taskbar items (useful to move something like the Transcript or Repository window to the front of the Taskbar)