Skip to content

Move some debugger related code of Process to debugger packages #15799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

jecisc
Copy link
Member

@jecisc jecisc commented Dec 15, 2023

This removes some code from the Kernel that is used only in the debugging tools.

Maybe we should merge Debugging-Core and Debugger-Model? Idk, sometimes I don't know what to put in what between those two

This removes some code from the Kernel that is used only in the debugging tools. 

Maybe we should merge Debugging-Core and Debugger-Model? Idk, sometimes I don't know what to put in what between those two
@Ducasse Ducasse requested a review from guillep December 15, 2023 18:11
@Ducasse
Copy link
Member

Ducasse commented Dec 15, 2023

Hi cyril how do you know that the behavior is not used by the unwind mechanism or ensure:, ifCurtailed:,...

@jecisc
Copy link
Member Author

jecisc commented Dec 15, 2023

I checked all senders one by one :)

@StevenCostiou
Copy link
Collaborator

One remark (I will review the PR later I cannot now): I think this kind of change is good in the sense that we can isolate debugger code that should not be that deep embeded in the system core.

Pushing it further, why do we have debugger code in the system core?

  • we should be able to run a system without debugging support
  • we should be able to completely isolate the debugger (in the large sense, not only the NewTool) and (un)load it when needed

I want to try to find a few months full time next year to investigate that and possibly start implementing changes.

@StevenCostiou
Copy link
Collaborator

Implicit message @jecisc : wait next year before merging core and model so that we can discuss the design :P
I think they should be merged but perhaps some code should get its own package.

@jecisc
Copy link
Member Author

jecisc commented Apr 5, 2024

Ping

@jecisc jecisc changed the base branch from Pharo12 to Pharo13 April 26, 2024 23:23
@jecisc
Copy link
Member Author

jecisc commented Apr 26, 2024

I updated the base

@jecisc
Copy link
Member Author

jecisc commented May 17, 2024

Hi, this PR is a green for a while, any chance to get a review? :) (It's not urgent but it was not an easy change to think about what should go where and I'm afraid I'll end up with a conflict that will be hard to resolve at some point :p)

@Ducasse Ducasse merged commit c0bef0b into pharo-project:Pharo13 Jun 13, 2024
@jecisc jecisc deleted the misc/move-out-debugger-code branch July 18, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants