Skip to content

Test added and findNode fixed with O(1) complexity #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

virenvarma007
Copy link
Contributor

No description provided.

@jordanmontt
Copy link
Member

Thanks @virenvarma007 !

Some observations:

  • Could you find another name for the instance variable dictNodes ? please
  • Can you format the code?
  • The test is good, but can you rename testdictNodes to something else? Also, can you add other tests that.
    1. The test does not call the run method. Only test that setting and getting the nodes works well.
    2. Some other tests that test only one simple thing

@jordanmontt jordanmontt merged commit e33c6f9 into pharo-ai:master Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants