Add tag limit and glob format #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theory
force-pushed
the
v2-updates
branch
2 times, most recently
from
14fd1bd to
36643b2
Compare
Use [wax] to validate globs. Since it checks for both `.` and `..` components, disallow both for paths and globs, except at the start of an expression. May or may not switch away from wax in the future, since its syntax is somewhat different from gitignore. For now, though, the RFC has been [updated] to reflect this change. Also limit the number of tags to 32, also reflecting a recent RFC change. [wax]: https://crates.io/crates/wax [updated]: pgxn/rfcs@4021dee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use wax to validate globs. Since it checks for both
.and..components, disallow both for paths and globs, except at the start of an expression. May or may not switch away from wax in the future, since its syntax is somewhat different from gitignore. For now, though, the RFC has been updated to reflect this change.Also limit the number of tags to 32, also reflecting a recent RFC change.