Avoid fast-path in --sh-boot script for PEX_PYTHON, PEX_PYTHON_PATH and PEX_PATH
#2729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huonw
commented
Mar 31, 2025
Comment on lines
+362
to
+368
| for env in [dict(PEX_PYTHON="FIXME"), dict(PEX_PYTHON_PATH="FIXME")]: | ||
| output = subprocess.check_output( | ||
| args=[pex, "-c", "import sys; print(sys.version)"], | ||
| env=make_env(PEX_ROOT=pex_root, **env), | ||
| stderr=subprocess.STDOUT, | ||
| ) | ||
| assert False, "FIXME" |
There was a problem hiding this comment.
I am unclear on how to test these (and ran out of time today to investigate existing tests that use them): AIUI, the tests are run by tox with a specific interpreter available, and other may not be.
If there's a tip for how these should be structured, that'd be appreciated, otherwise I'll look at existing tests more, soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #2726, there's some additional variables that are need to avoid the
--sh-bootfast-path.