-
-
Notifications
You must be signed in to change notification settings - Fork 298
Optimize pure delete lock updates. #2569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When a lock update only asks for deletes, we now process the "resolve" offline without consulting Pip. Fixes pex-tool#2566
N.B.: Existing tests cover all the interesting delete cases, including transitive dependencies of deleted node being partially retained when something else depends on those, and they pass. Here proj-b 1 depends on proj-a and proj-c: pex/tests/integration/cli/commands/test_lock_update_issues_2332_2334.py Lines 441 to 464 in e0aac4f
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I claimed there was already one of these in pex-tool#2569 but I was wrong because the existing complex case test include an update; so is not a pure delete. Add a new test of the pure delete case where the deleted node's graph is partially retained.
My claim of an existing complex delete case in #2569 (comment) was a lie, only simple deletes are tested through the new code path. That case has a delete and an update; so does not use the new code path and uses Pip instead. I've added a complex pure delete test case in #2576. It passes with no changes; so I'll process with the release before landing that change. |
I claimed there was already one of these in #2569 but I was wrong because the existing complex case test include an update; so is not a pure delete. Add a new test of the pure delete case where the deleted node's graph is partially retained.
When a lock update only asks for deletes, we now process the "resolve"
offline without consulting Pip.
Fixes #2566