Migrate many types from str to Text. #2263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This supports an up coming refactor of `pex.{dist_metadata,pep_376}`
which also requires re-formulating the pyc filters from `Iterable` ->
`Iterable` form to boolean predicates to making typing easier at the
loss of ~nothing.
|
I believe the CI errors are fixed by #2262. I'll wait on that and then merge it here to see if that's true. |
huonw
approved these changes
Oct 9, 2023
benjyw
approved these changes
Oct 9, 2023
huonw
added a commit
that referenced
this pull request
Nov 10, 2023
This fixes #2285 by fixing a minor typo in f9a9d94 / #2263 that caused the computation of a PEXes code hash to not recur into the correct directories. I think this explains the symptoms in #2285 due to caching: if a PEX only contains files in subdirectories, the code hash will be `da39a3ee5e6b4b0d3255bfef95601890afd80709` (the sha256 hash of no data) and thus potentially the `venv create` might be referring to an incorrectly cached installation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports an up coming refactor of
pex.{dist_metadata,pep_376}which also requires re-formulating the pyc filters from
Iterable->Iterableform to boolean predicates to make typing easier at theloss of ~nothing.