-
-
Notifications
You must be signed in to change notification settings - Fork 298
linux wheel "link matching" behavior changes when using pip 25.1 #2753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I have a feeling this is dup to #2752, but thanks for the extra data. Like that discussion, I probably won't have a chance to address until ~5/9. I'd suggest not using Pip 25.1 until the next Pex release. |
Understood, and enjoy your afk time! |
cburroughs
added a commit
to cburroughs/pants
that referenced
this issue
May 6, 2025
This includes the platforms for the same wheels that have historically been in the lockfile. See pex-tool/pex#2753 for background. ``` Lockfile diff: 3rdparty/python/user_reqs.lock [python-default] == Upgraded dependencies == certifi 2025.1.31 --> 2025.4.26 charset-normalizer 3.4.1 --> 3.4.2 cryptography 44.0.2 --> 44.0.3 h11 0.14.0 --> 0.16.0 pydantic 1.10.21 --> 1.10.22 soupsieve 2.6 --> 2.7 ```
cburroughs
added a commit
to cburroughs/pants
that referenced
this issue
May 6, 2025
This restores wheels for the same platforms that have historically been in the lockfile. See pex-tool/pex#2753 for background. ``` Lockfile diff: 3rdparty/python/user_reqs.lock [python-default] == Upgraded dependencies == charset-normalizer 3.4.1 --> 3.4.2 cryptography 44.0.2 --> 44.0.3 ```
cburroughs
added a commit
to pantsbuild/pants
that referenced
this issue
May 6, 2025
This includes the platforms for the same wheels that have historically been in the lockfile. See pex-tool/pex#2753 for background. ``` Lockfile diff: 3rdparty/python/user_reqs.lock [python-default] == Upgraded dependencies == certifi 2025.1.31 --> 2025.4.26 charset-normalizer 3.4.1 --> 3.4.2 cryptography 44.0.2 --> 44.0.3 h11 0.14.0 --> 0.16.0 pydantic 1.10.21 --> 1.10.22 soupsieve 2.6 --> 2.7 ```
Alright, the fix is out in https://github.com/pex-tool/pex/releases/tag/v2.37.0. Thanks for the review @cburroughs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Pex includes different artifacts when using pip 25.1 than pip 25.0. This is show by the differences in Found vs Skipping links in the examples below.
(I presume to how differences in pip 25.1 colliding with the custom patching, so for anyone else following along the log lines are "from pip", but the
pip._internal.models.wheel.Wheel.supported
behavior is from pex.)(So that's the
pex-linux-x86_64
release and this is running on x86_64 Linux)All together as a lockfile diff
Comparing vanilla
pip
behavior (from a git checkout and editable install):So when run from
x86_64
, pip matches onx86_64
and noti686
. Historically, Pex matched on bothx86_64
andi686
, but now when combined with pip 25.1 matches neither.The text was updated successfully, but these errors were encountered: