Call functions inside module with module.exports #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frozzare
added a commit
that referenced
this pull request
Aug 28, 2019
|
Thanks! Not sure why is not working. I did another fix that solves this problem without using Will create a new release and you are welcome to test the new commit. 8d17aa7 |
|
👍 |
|
Great! Tested it and works perfectly. Saved me from having to implement format() myself 😅👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I use personnummer.format() it throws a
TypeError: Cannot read property 'valid' of undefinederror. I'm not sure why but I suspect is has to do with the scope not being correct. With these code changes it seems to work.The unit tests also run ok.