remove text-direction from book.toml #6
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setting the language to "fa" should make the book rtl
As far as I know
text-direction = "rtl"
is now unnecessary as thelanguage = "fa"
setting should already sets the book tortl
. https://github.com/rust-lang/mdBook/blob/3052fe38270bb370dcf54009d450c5395537d975/src/config.rs#L466Currently this is the only mdboik I am aware of that uses this option. See https://mdbooks.code-maven.com/text-direction
Before I propose the change to the
mdbook
project, I'd like to ask you to verify that indeed thelanguage = "fa"
setting is enough for you as well.