Added inlineRequires handling for srcset #188
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Sep 30, 2019
|
|
||
| if (match.indexOf(',') > -1) { | ||
| // Handle srcset | ||
| const srcset = match.split(','); |
There was a problem hiding this comment.
Parsing error: The keyword 'const' is reserved
There was a problem hiding this comment.
ESLint defaults to ES5 syntax-checking. You'll want to override to the latest well-supported version of JavaScript. If that's not possible, I will switch back to ES5 syntax.
pcardune
force-pushed
the
main
branch
2 times, most recently
from
384113d to
a4f23d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue with
inlineRequiresfeature not able to handlesrcsetresources because of different syntax.Fixes #148.