Skip to content

fix git-lfs not being detected on windows #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

Merith-TK
Copy link
Contributor

@Merith-TK Merith-TK commented Apr 19, 2024

On windows git-lfs is not a command, however (exclusively) on windows, git comes with lfs bundled into it by default, so git lfs, with a space, is needed

this does indeed work on linux as well,
image
left is a linux machine right is my local windows machine,

On windows `git-lfs` is not a command, however git comes with `lfs` bundled into it by default, so `git lfs`, with a space, is needed

this does indeed work on linux as well,
@Merith-TK
Copy link
Contributor Author

before I applied the patch

[09:31:01] [main/INFO] (fastback) git is installed: git version 2.42.0.windows.2
[09:31:01] [main/WARN] (fastback) git-lfs is not installed.

after

[09:32:19] [main/INFO] (fastback) git is installed: git version 2.42.0.windows.2
[09:32:19] [main/INFO] (fastback) git-lfs is installed: git-lfs/3.4.0 (GitHub; windows amd64; go 1.20.6; git d06d6e9e)

@pcal43 pcal43 self-requested a review April 19, 2024 18:51
@pcal43 pcal43 self-assigned this Apr 19, 2024
@pcal43 pcal43 added the bug Something isn't working label Apr 19, 2024
Copy link
Owner

@pcal43 pcal43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm, right. I guess not surprising windows would do things differently.

Thanks.

@pcal43 pcal43 merged commit 413fa5e into pcal43:main Apr 19, 2024
@Merith-TK
Copy link
Contributor Author

Going to make a few more tweaks based off some things I have found in further testing, as it appears git does internally call git-lfs,(seeing an error where it is throwing git-lfs not found by the mod, but when I run the command directly it has no problem???)
which I know we had an... argument about in the past so im waving the flag on that one and saying you right lol

there is a command called git --exec-path where git returns one of its internal directories, going to see if I can patch that to be injected into the PATH of the runtime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants