[fix] crash if SignerSignEx failed

[heliosgg]

zadig crashed due to bad incorrect VA_ARGS

[pbatard]

Thanks for spotting that one! I'll apply your patch when I get a chance.

[heliosgg]

When you apply this fix I will probably create an issue.
For some reason SignerSignEx fails with the error "invalid algorithm"
If I replace CALG_SHA_256 with CALG_SHA1 it works.
I can't know the reason for this problem

[pbatard]

"invalid algorithm" has to be an issue with your specific environment. Depending on your Windows version and configuration, some crypto algorithms may not be available.

For instance, if you look at https://learn.microsoft.com/en-us/windows/win32/seccrypto/alg-id, you will see that CALG_SHA_256 is supported by Microsoft Enhanced RSA and AES Cryptographic Provider rather than the Microsoft Base Cryptographic Provider.

On a standard installation of a modern version of Windows (Windows 10 or later), both the Microsoft Base Cryptographic Provider and the Microsoft Enhanced RSA and AES Cryptographic Provider come as default.

But you (or your corporate environment if you use one) may be able to modify the providers installed to disable the Microsoft Enhanced one.

Obviously, this is not a configuration I can to support, so if you find that the Microsoft Enhanced RSA and AES Cryptographic Provider is not available in your environment, this is something you will have to fix on your end.

[heliosgg]

OK, I will try to enable "Microsoft Enhanced RSA and AES Cryptographic Provider".
I think that my environment is casual (windows 11 23h2), but for some reason this provider probably is not enabled
thank you

[pbatard]

Applied. Thanks again for finding out the bug and proposing a fix!