Skip to content

Prevent loading of unused backends #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Conversation

tobiasah
Copy link
Contributor

@tobiasah tobiasah commented Sep 5, 2023

This change changes how the backends are imported, instead of importing all of them every backend is
loaded lazy only when its needed.

This solves the problem that dependencies from unused backends need to be installed even if the are not
used (e.g. symspellpy depends on editdistpy which
needs to be build from source on Windows requiring a compiler ...).

tobiasah and others added 2 commits September 5, 2023 08:22
This change changes how the backends are imported,
instead of importing all of them every backend is
loaded lazy only when its needed.

This solves the problem that dependencies from unused
backends need to be installed even if the are not
used (e.g. symspellpy depends on editdistpy which
needs to be build from source on Windows requiring a
compiler ...).
Copy link
Owner

@pawamoy pawamoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch! Locally we always have everything installed so I didn't think about this 🙂

@pawamoy pawamoy merged commit 12062ff into pawamoy:master Sep 5, 2023
@pawamoy
Copy link
Owner

pawamoy commented Sep 5, 2023

Released in 1.0.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants