Skip to content

Bug - [NavList] - [Scroll buttons no longer show up when resizing] #10897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jelly opened this issue Sep 3, 2024 · 3 comments · Fixed by #11099
Closed

Bug - [NavList] - [Scroll buttons no longer show up when resizing] #10897

jelly opened this issue Sep 3, 2024 · 3 comments · Fixed by #11099
Assignees
Labels
Milestone

Comments

@jelly
Copy link
Contributor

jelly commented Sep 3, 2024

Describe the problem

In our automated pixel test we no longer see the left/right scroll buttons to browse through a navlist when the display is too small to see all nav items. When we refresh the page the buttons show up again.

This problem started in an upgrade to 5.4.0 for us.

How do you reproduce the problem?

I can reproduce this with the NavList Tertiary Demo

Expected behavior

Buttons show up.

Is this issue blocking you?

For now we work around it in the test.

Screenshots

Demo screencast:
Screencast from 2024-09-03 14-20-53.webm

What is your environment?

  • OS: Red Hat Linux
  • Browser Firefox
  • Version latest

What is your product and what release date are you targeting?

Cockpit, none.

Any other information?

@jelly jelly added the bug label Sep 3, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Sep 3, 2024
@jelly jelly changed the title Bug - [Component] - [short description] Bug - [NavList] - [Scroll buttons no longer show up when resizing] Sep 3, 2024
@tlabaj tlabaj modified the milestones: 2024.Q4, 2024.Q3 Sep 5, 2024
@tlabaj tlabaj moved this from Needs triage to Not started in PatternFly Issues Sep 5, 2024
@tlabaj tlabaj self-assigned this Sep 30, 2024
@tlabaj tlabaj moved this from Not started to Done in PatternFly Issues Oct 8, 2024
@tlabaj tlabaj linked a pull request Oct 8, 2024 that will close this issue
@tlabaj
Copy link
Contributor

tlabaj commented Oct 8, 2024

closed by #11099

@tlabaj tlabaj closed this as completed Oct 8, 2024
martinpitt added a commit to martinpitt/cockpit that referenced this issue Oct 21, 2024
It's not marked as "latest" yet, it's in the v5-prerelease channel.

This re-fixes the tertiary nav scroll buttons that regressed in 5.4.0:
patternfly/patternfly-react#10897

Fixes cockpit-project#21137
martinpitt added a commit to martinpitt/cockpit that referenced this issue Oct 21, 2024
It's not marked as "latest" yet, it's in the v5-prerelease channel.

This re-fixes the tertiary nav scroll buttons that regressed in 5.4.0:
patternfly/patternfly-react#10897

Fixes cockpit-project#21137
jelly pushed a commit to cockpit-project/cockpit that referenced this issue Oct 21, 2024
It's not marked as "latest" yet, it's in the v5-prerelease channel.

This re-fixes the tertiary nav scroll buttons that regressed in 5.4.0:
patternfly/patternfly-react#10897

Fixes #21137
SludgeGirl pushed a commit to Nykseli/cockpit that referenced this issue Nov 12, 2024
It's not marked as "latest" yet, it's in the v5-prerelease channel.

This re-fixes the tertiary nav scroll buttons that regressed in 5.4.0:
patternfly/patternfly-react#10897

Fixes cockpit-project#21137
@mvollmer
Copy link

This bug is back with Patternfly 6. The fix #11099 seems to be missing from it.

@tlabaj
Copy link
Contributor

tlabaj commented Apr 22, 2025

cc @nicolethoen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants