Skip to content

feat(sdk): Overhaul of tesseract serve #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Conversation

dionhaefner
Copy link
Contributor

Relevant issue or PR

#154
#156

Description of changes

Mega-PR for now, will likely split later for efficient review

Testing done

CI

License

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I sign the Developer Certificate of Origin below by adding my name and email address to the Signed-off-by line.
Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Signed-off-by: Dion Häfner [email protected]

Copy link

codecov bot commented May 12, 2025

Codecov Report

Attention: Patch coverage is 76.23762% with 24 lines in your changes missing coverage. Please review.

Project coverage is 75.49%. Comparing base (fe9a90c) to head (ee2c89a).

Files with missing lines Patch % Lines
tesseract_core/sdk/config.py 71.42% 11 Missing and 1 partial ⚠️
tesseract_core/sdk/docker_client.py 77.27% 8 Missing and 2 partials ⚠️
tesseract_core/sdk/engine.py 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
- Coverage   75.59%   75.49%   -0.10%     
==========================================
  Files          27       28       +1     
  Lines        2946     3020      +74     
  Branches      456      470      +14     
==========================================
+ Hits         2227     2280      +53     
- Misses        517      535      +18     
- Partials      202      205       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dionhaefner
Copy link
Contributor Author

@heitorPB want to check with your podman setup why this fails please?

@heitorPB
Copy link
Contributor

heitorPB commented May 12, 2025

I can build and apply vectoradd_jax:

$ tesseract build examples/vectoradd_jax
 [i] Building image ...
 [i] Built image sha256:9f2447894284, ['docker.io/library/vectoradd_jax:latest']
["docker.io/library/vectoradd_jax:latest"]

$ tesseract run vectoradd_jax apply @examples/vectoradd_jax/example_inputs.json
{"vector_add":{"result":{"object_type":"array","shape":[3],"dtype":"float32","data":{"buffer":[13.0,17.0,21.0],"encoding":"json"}},"normed_result":{"object_type":"array","shape":[3],"dtype":"float32","data":{"buffer":[0.43357428908348083,0.5669817328453064,0.7003892064094543],"encoding":"json"}}},"vector_min":{"result":{"object_type":"array","shape":[3],"dtype":"float32","data":{"buffer":[-11.0,-13.0,-15.0],"encoding":"json"}},"normed_result":{"object_type":"array","shape":[3],"dtype":"float32","data":{"buffer":[-0.4847179055213928,-0.5728484392166138,-0.6609789729118347],"encoding":"json"}}}}

All E2E tests pass locally. It is something in the CI

@dionhaefner
Copy link
Contributor Author

Superseded by #161 and #162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants