Ignore custom-elements for selector-type-no-unknown
#21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalduez
approved these changes
Jun 20, 2025
|
Available as of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the ruleset into consistency with the official base
stylelint-config-recommendedruleset, which ignorescustom-elements:https://github.com/stylelint/stylelint-config-recommended/blob/f862a67da107449c3e7ccc8ffd034fb28dd789af/index.js#L47C14-L47C31
If
stylelint-config-css-modulesis used in conjunction, it overrides that base rule, dropping the ignoring ofcustom-elements, in turn requiring a local override to bring it back. Since there's no reason to differ from the standard ruleset to support CSS modules, it's best to align.