Skip to content

Tracking issue for typos in current partiql specification #33

Open
@alancai98

Description

@alancai98

While porting some tests from the PartiQL specification to the conformance test repo, partiql-tests, I noticed some typos in the examples. Below lists some of the encountered typos:

  • Example 8 -- can't use a keyword as an identifier. Resolution is to either use double quotes around symbol (which loses case-insensitivity) or change the name of symbol
  • Example 10 -- quotes missing around the v binding
  • Example 11 -- missing comma after first line of readings in initial environment
  • Example 18, 19, 20, 21 -- for each of these examples, missing the v alias in the FROM sources
  • Example 22 -- similar to "Example 8"; can't use keyword symbol as identifier without double quotes
  • Example 26 -- the result should be in a bag not an array
  • Example 29 -- {’a’:1, ’b’:2} = {’a’:1} repeated example
  • Example 30 -- should be SELECT VALUE rather than SELECT VALUES
  • following Example 40 on page 38 -- GROUPY -> GROUP BY
  • Example 44 -- SELECT aliases for avg and count need double quotes since they are keywords
  • Example 47 -- in globals, TIMESTAMP value constructor syntax not supported. Perhaps the TIME constructor syntax is intended here? -- tracking in PartiQL spec example 47 (section 11.3) unspecified timestamp syntax #72
  • Example 49 -- missing FROM source alias x
PIVOT x.v AT x.a
FROM << {'a': 'first', 'v': 'john'}, {'a': 'last', 'v': 'doe'} >> AS x

Other typos:

  • Inconsistent single quotation markings in the examples -- using rather than ' (the former is not parseable), which made it harder to copy and paste examples from the specification
  • Inconsistent bag operator in examples << ... >>. Not as annoying since they copy and pasted the same
  • "An PartiQL ..." rather than "A PartiQL"

Feel free to comment any other errors/typos encountered, and I will update the issue.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions