Skip to content

Removed NAry operator in SqlParser.kt #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

lziq
Copy link
Contributor

@lziq lziq commented Feb 24, 2022

Motivation:
Currently, part of parser's code still uses NAry, which are ExprNode operators. We need to remove them as well.

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2022

Codecov Report

Merging #534 (fc51fcc) into deprecate-exprnode (8726cb9) will decrease coverage by 0.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@                   Coverage Diff                    @@
##             deprecate-exprnode     #534      +/-   ##
========================================================
- Coverage                 80.38%   80.36%   -0.02%     
  Complexity                 1680     1680              
========================================================
  Files                       196      196              
  Lines                     14413    14411       -2     
  Branches                   2984     2983       -1     
========================================================
- Hits                      11586    11582       -4     
- Misses                     1855     1858       +3     
+ Partials                    972      971       -1     
Flag Coverage Δ
CLI 26.53% <ø> (ø)
EXAMPLES 74.71% <ø> (ø)
LANG 82.11% <85.71%> (-0.02%) ⬇️
PTS ∅ <ø> (∅)
TEST_SCRIPT 76.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lang/src/org/partiql/lang/syntax/SqlParser.kt 76.74% <85.71%> (-0.10%) ⬇️
lang/src/org/partiql/lang/ast/ast.kt 86.05% <0.00%> (-0.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8726cb9...fc51fcc. Read the comment docs.

@lziq lziq merged commit 93ea6d6 into deprecate-exprnode Feb 24, 2022
@lziq lziq deleted the deprecate-exprnode-NAry branch February 24, 2022 01:29
@lziq lziq mentioned this pull request Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants