Skip to content

Optimizes AST iterator #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Optimizes AST iterator #391

merged 1 commit into from
Apr 22, 2021

Conversation

abhikuhikar
Copy link
Contributor

Issue #, if available:

Description of changes:
Changed AST iterator() to use mutable list for optimizing performance.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@almann almann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is reasonable--how did you test it to make sure it does what you want (even if said perf testing was manual)?

@abhikuhikar
Copy link
Contributor Author

I observed the "wall-clock" for the multiple runs and the previous iterator() took about 119 secs on average and the new iterator() took about 1.5 secs on average.

@abhikuhikar abhikuhikar reopened this Apr 22, 2021
@abhikuhikar abhikuhikar merged commit eee99ae into master Apr 22, 2021
abhikuhikar added a commit that referenced this pull request Apr 22, 2021
abhikuhikar added a commit that referenced this pull request Apr 27, 2021
* Optimizes AST iterator (#391)

* Prepare v0.1.5 release
@dlurton dlurton added this to the v0.3.0 milestone Jun 9, 2021
@alancai98 alancai98 deleted the optimize-ast-iterator branch September 13, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants