Fix parsing of TRIM specification keywords (BOTH, LEADING, and TRAILING)
#326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #326 +/- ##
============================================
- Coverage 82.37% 82.35% -0.02%
Complexity 1233 1233
============================================
Files 157 157
Lines 9366 9365 -1
Branches 1526 1526
============================================
- Hits 7715 7713 -2
Misses 1192 1192
- Partials 459 460 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
therapon
approved these changes
Nov 14, 2020
dlurton
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the parsing of
TRIMspecification keywords-BOTH,LEADING, andTRAILING(fixes #316). This ensures they are no longer treated as string literals except when used as the first argument of a call to theTRIMfunction.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.