Skip to content

Temporarily disable REPL tests due to race condition. #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

dlurton
Copy link
Contributor

@dlurton dlurton commented Jul 31, 2020

This race condition is not caused by production code--just the tests.

This one is driving me bonkers--I don't have the time to fix this properly right now. I've created #266 so we don't forget to un-@Ingore this later.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This race condition is not caused by production code--just the tests. #266
has been filed to fix this.
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2020

Codecov Report

Merging #267 into master will decrease coverage by 1.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #267      +/-   ##
============================================
- Coverage     84.00%   82.93%   -1.08%     
+ Complexity     1228     1200      -28     
============================================
  Files           155      155              
  Lines          9614     9614              
  Branches       1599     1599              
============================================
- Hits           8076     7973     -103     
- Misses         1047     1164     +117     
+ Partials        491      477      -14     
Flag Coverage Δ Complexity Δ
#CLI 17.66% <ø> (-36.40%) 19.00 <ø> (-28.00)
#EXAMPLES 75.34% <ø> (ø) 27.00 <ø> (ø)
#LANG 85.67% <ø> (ø) 997.00 <ø> (ø)
#PTS 100.00% <ø> (ø) 0.00 <ø> (ø)
#TEST_SCRIPT 79.68% <ø> (ø) 157.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
cli/src/org/partiql/cli/Repl.kt 0.00% <0.00%> (-75.74%) 0.00% <0.00%> (-28.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1842309...980eaf5. Read the comment docs.

@dlurton dlurton changed the title Temporarily disable CLI tests due to race condition. Temporarily disable REPL tests due to race condition. Jul 31, 2020
@dlurton dlurton merged commit f54d52b into master Jul 31, 2020
@dlurton dlurton deleted the disable-cli-tests branch July 31, 2020 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants