Prepare 0.14.8 release #1554
Prepare 0.14.8 release #1554
Conversation
Conformance comparison report
Number passing in both: 5384 Number failing in both: 434 Number passing in Base (945558c) but now fail: 0 Number failing in Base (945558c) but now pass: 0 |
There was a problem hiding this comment.
I only have one comment on the PR prior: https://github.com/partiql/partiql-lang-kotlin/pull/1551/files#r1722324893
May be worth making the small adjustment prior to release.
| when (val constr = decimalType.precisionScaleConstraint) { | ||
| is DecimalType.PrecisionScaleConstraint.Constrained -> { | ||
| val precision = max(constr.precision, acc.first) | ||
| val scale = max(constr.scale, acc.second) | ||
| precision to scale | ||
| } | ||
| is DecimalType.PrecisionScaleConstraint.Unconstrained -> { | ||
| return StaticType.DECIMAL // Default constructor is unconstrained | ||
| } | ||
| } |
There was a problem hiding this comment.
+1 on your original statement here: https://github.com/partiql/partiql-lang-kotlin/pull/1551/files#r1722324893
Hence the is DecimalType.PrecisionScaleConstraint.Unconstrained is a dead branch.
Perhaps we should do something like
val constr = decimalType.precisionScaleConstraint as? DecimalType.PrecisionScaleConstraint.Constrained
?: throw InternalException(...)
Instead of slightly pass through if somewhere there is a bug.
There was a problem hiding this comment.
Yeah, agree that if there really is a bug, we should opt to error rather than pass-through. In the latest commit 873b6c4 (#1554),
- applied your suggestion to give an error
- renamed
computeDecimaltocomputeConstrainedDecimalfor clarity
alancai98
force-pushed
the
prep_0_14_8_set
branch
from
164466a to
873b6c4
Compare
Relevant Issues
Description
Other Information
Updated Unreleased Section in CHANGELOG: [YES]
Any backward-incompatible changes? [NO]
Any new external dependencies? [NO]
Do your changes comply with the Contributing Guidelines
and Code Style Guidelines? [YES]
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.