-
Notifications
You must be signed in to change notification settings - Fork 63
Simplifies logical model of the path expression #1306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Conformance comparison report
Number passing in both: 5384 Number failing in both: 434 Number passing in Base (c7c7972) but now fail: 0 Number failing in Base (c7c7972) but now pass: 0 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1306 +/- ##
=========================================
Coverage 72.16% 72.16%
Complexity 2097 2097
=========================================
Files 221 221
Lines 15974 15974
Branches 2892 2892
=========================================
Hits 11528 11528
Misses 3640 3640
Partials 806 806
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
f4541b9
to
5578b9d
Compare
Relevant Issues
Description
Path
, in this PR, is a single step on some root. Therefore, we can directly compile logical plan nodes into physical plan nodes that represent the underlying operation (i.e. index lookup, sensitive lookup, insensitive lookup).ExprPath
and attempt to grab the first steps to make a qualified identifier (Var Unresolved). This subtle change gives us the ability to attempt to resolve the qualified identifier in the planner without needing to maintain the syntactic metadata in the logical unresolved plan. See Modifies how we model paths in the plan #1271Other Information
and Code Style Guidelines? YES
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.